Getting started

How to start contributing to the code of the CKI project

Red Hat associate

If you are a Red Hat associate getting started on the CKI team, start with the internal onboarding documentation.

Development setup

Linux distribution

To start contributing, you don’t need any specific Linux distribution. While we encourage everyone to develop on Fedora Workstation or Fedora Silverblue, this is not a requirement. Where Fedora/RHEL-specific software is needed, container-based alternative workflows are provided.

Python version

In general, you are encouraged to use the latest stable version.

For the GitLab pipeline, code needs to be compatible with the minimal Python version across all pipeline images.

For services outside the pipeline, code needs to be compatible with the Fedora Python version used in all container images.

Install dependencies

We need to install direnv, tox and git.

Fedora Workstation

All should be packaged for most distributions and be installable with something like

sudo dnf install tox direnv git

RHEL 9

  • Install Git

    sudo dnf install git
    
  • Install tox from EPEL for RHEL 9

    sudo subscription-manager repos --enable codeready-builder-for-rhel-9-$(arch)-rpms
    sudo dnf install https://dl.fedoraproject.org/pub/epel/epel-release-latest-9.noarch.rpm
    sudo dnf install tox
    
  • Install direnv from Fedora Koji

    sudo dnf install https://kojipkgs.fedoraproject.org/packages/direnv/2.32.1/6.fc39/$(arch)/direnv-2.32.1-6.fc39.$(arch).rpm
    

Setup direnv

If you’ve just installed direnv, follow the instructions in the direnv setup doc, to hook it to your shell.

Git config

Configure a global .gitignore file and add entries for direnv to it via something like

IGNORE_FILE=$HOME/.config/git/excludes
git config --global core.excludesfile "${IGNORE_FILE}"
mkdir -p "${IGNORE_FILE%/*}"
echo "/.envrc" >> "${IGNORE_FILE}"
echo "/.direnv/" >> "${IGNORE_FILE}"

Cloning CKI repositories and creating forks

For both GitLab instances, create api GitLab personal access tokens. The tokens are going to be stored in the COM_GITLAB_TOKEN_PERSONAL and CEE_GITLAB_TOKEN_PERSONAL environment variables below.

The following bash commands temporarily bootstrap cki-tools, and then use the included repo-manager module to clone all repositories including forks and setup pip:

mkdir ~/git-temp ~/git-cki
cd ~/git-temp
echo "export GITLAB_TOKENS='{\"gitlab.com\":\"COM_GITLAB_TOKEN_PERSONAL\", \"gitlab.cee.redhat.com\":\"CEE_GITLAB_TOKEN_PERSONAL\"}'" > .envrc
echo 'export COM_GITLAB_TOKEN_PERSONAL="your-secret-token-from-gitlab-com"' >> .envrc
echo 'export CEE_GITLAB_TOKEN_PERSONAL="your-secret-token-from-gitlab-cee"' >> .envrc
echo 'export REQUESTS_CA_BUNDLE=/etc/pki/tls/certs/ca-bundle.crt' >> .envrc
cp .envrc ~/git-cki/
git clone git@gitlab.com:cki-project/cki-tools
cd cki-tools
printf 'layout python python3.11\nsource_up\n' > .envrc
direnv allow
python3 -m pip install -e .
python3 -m cki.cki_tools.repo_manager --directory ~/git-cki --fork fork  --venv --force
cd ~/git-cki
rm -rf ~/git-temp

The venv setup depends on the ability to install the required dependencies. This can fail if e.g. no wheels are available for your Python version or the required development packages are not available to compile the requirements from source.

For Fedora, you can fix most of these via

dnf install -y gcc krb5-devel libpq-devel openldap-devel python3-devel

Linting and tests

Python-based projects

Linting is implemented in cki_lint.sh, while unit tests and code coverage checks are implemented in cki_test.sh and can both be invoked in a clean environment by running

tox

You can pass arguments to cki_lint.sh and cki_test.sh following the cki-lib README.md. For example, with the environment variable CKI_PYTEST_ARGS, the following code runs only on test_name in tests/test_file_name.py:

TOX_OVERRIDE=testenv.passenv=CKI_PYTEST_ARGS \
CKI_PYTEST_ARGS="tests/test_file_name.py::class_name::test_name" \
tox

To run tox with a different Python version, explicitly specify the Python interpreter via

python3.9 -m tox

In the case of host problems, e.g. if no venv is available, the Python version is too old or certificates are not setup correctly, tox can also be run in a container via

podman run --rm --workdir /code --volume .:/code:z \
    quay.io/cki/cki-tools:production \
    tox --workdir .tox-container

To run only in a subset of the tests use CKI_PYTEST_ARGS:

podman run --rm --workdir /code --volume .:/code:z \
    --env TOX_OVERRIDE=testenv.passenv=CKI_PYTEST_ARGS \
    --env CKI_PYTEST_ARGS="tests/test_file_name.py[::class_name[::test_name]] ..." \
    quay.io/cki/cki-tools:production \
    tox --workdir .tox-container

Individual tests can also be run directly on the host via any of

python3 -m unittest tests.test_module
python3 -m unittest tests/test_file_name.py
pytest tests/test_file_name.py

The cki-lib README.md file contains the parameters for correct editor integration of linters/fixers for CKI code.

Pipeline code

In com/pipeline-definition, the linting and testing can be invoked locally via

./lint.sh
./tests.sh

or in a container via

podman run --rm --workdir /code --volume .:/code:z \
    quay.io/cki/cki-tools:production \
    ./lint.sh
podman run --rm --workdir /code --volume .:/code:z \
    quay.io/cki/builder-rawhide:production \
    ./tests.sh